-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First commits #1
base: develop
Are you sure you want to change the base?
Conversation
This link was mistakenly changed by gh skeleton clone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, aside from one documentation question.
Co-authored-by: Dave Redmin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems straightforward enough. 👍
version.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we may benefit from having a tag.sh
that is used solely to generate the major (vX
) and minor (vX.Y
) tags based on the full version tag that would generated when creating a release (if we don't want the script to just create all three and then just select the full version tag when creating the release).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about that too. This afternoon I started creating a release workflow that will create those tags automatically when a release is created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see commits 4156a58 through 666579b, as well as the following GitHub Actions runs:
- https://github.com/cisagov/skeleton-action-composite/actions/runs/13551125481
- https://github.com/cisagov/skeleton-action-composite/actions/runs/13551184170
Once @mcdonnnj resolves this conversation I will do a git rebase
to clean up the commit history, remove all the prereleases and tags generated during testing, etc. I think that stuff muddies the history for future folks who review the commits in this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, if @cisagov/vm-dev folks have any opinions as to my use of zyactions/semver versus any of the other GH Actions listed here please let me know. There are other actions listed there that do the same thing.
Co-authored-by: Nick <[email protected]>
This is being done for testing purposes and this commit will be reverted once testing is complete.
These are unnecessary since the trigger events guarantee that the reference type will always be a tag.
Otherwise the git push origin --delete command will fail.
This was done only for testing purposes (so I could trigger the workflow by creating prereleases) but now testing is complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty solid. Just a few minor suggestions for your consideration.
- id: checkout-code | ||
name: Checkout the code | ||
uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another consistency one.
- id: checkout-code | |
name: Checkout the code | |
uses: actions/checkout@v4 | |
- uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been trying to add an id
and name
for every step since I started working with the GH Actions jazz recently. What is your reasoning for not doing that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a reason to not do that, but we should start with cisagov/skeleton-generic and push it down in a consistent manner. This is specifically because we haven't done it with uses of actions/checkout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My intent was to take care of this inconsistency when I'm able to start using reusable workflows via cisagov/github-actions-workflows. In the meantime I'd like to continue using name
and id
in the new code I am creating.
Co-authored-by: Nick <[email protected]>
Co-authored-by: Nick <[email protected]>
🗣 Description
This pull request contains the first commits for a new skeleton for GitHub composite actions.
💭 Motivation and context
We need a skeleton of this type. See, for example, cisagov/action-disable-apparmor and cisagov/action-job-preamble.
🧪 Testing
All automated tests pass.
✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist