Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First commits #1
base: develop
Are you sure you want to change the base?
First commits #1
Changes from 5 commits
06e0b8a
2c6216e
f4d983b
0f95a68
26a14dc
e1054d8
23bc7e5
4156a58
66b3953
d270c90
81665bd
63e96c3
d2f145d
3284849
447a29e
d3e1d18
3fc68f0
9fd843f
a8fae25
911c3b7
d7f1317
b8837c0
e2ad30f
fa725b9
666579b
db7df1b
84dc3e9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we may benefit from having a
tag.sh
that is used solely to generate the major (vX
) and minor (vX.Y
) tags based on the full version tag that would generated when creating a release (if we don't want the script to just create all three and then just select the full version tag when creating the release).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about that too. This afternoon I started creating a release workflow that will create those tags automatically when a release is created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see commits 4156a58 through 666579b, as well as the following GitHub Actions runs:
Once @mcdonnnj resolves this conversation I will do a
git rebase
to clean up the commit history, remove all the prereleases and tags generated during testing, etc. I think that stuff muddies the history for future folks who review the commits in this repo.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, if @cisagov/vm-dev folks have any opinions as to my use of zyactions/semver versus any of the other GH Actions listed here please let me know. There are other actions listed there that do the same thing.