Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-commit hooks #142

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Update pre-commit hooks #142

merged 1 commit into from
Sep 13, 2023

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Aug 8, 2023

🗣 Description

This pull requests updates the pre-commit hooks in our configuration.

💭 Motivation and context

Regular updates are important!

🧪 Testing

Automated tests pass. I tested these updated hooks in a number of repositories and saw no issues.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added the dependencies Pull requests that update a dependency file label Aug 8, 2023
@mcdonnnj mcdonnnj self-assigned this Aug 8, 2023
@mcdonnnj mcdonnnj added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Aug 15, 2023
@mcdonnnj mcdonnnj force-pushed the maintenance/update_pre-commit_hooks branch from 2c62d30 to a6d434e Compare September 8, 2023 21:19
jsf9k
jsf9k approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved even harder!

@mcdonnnj mcdonnnj force-pushed the maintenance/update_pre-commit_hooks branch from a6d434e to 389b18d Compare September 11, 2023 21:47
@mcdonnnj mcdonnnj mentioned this pull request Sep 11, 2023
Merged
6 tasks
jsf9k
jsf9k approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval reaches a fever pitch!!!

@mcdonnnj mcdonnnj added this pull request to the merge queue Sep 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 13, 2023
@mcdonnnj
Update pre-commit hook versions
94d753d 
This is done automatically with the `pre-commit autoupdate` command.
@mcdonnnj mcdonnnj force-pushed the maintenance/update_pre-commit_hooks branch from 389b18d to 94d753d Compare September 13, 2023 01:46
@mcdonnnj mcdonnnj added this pull request to the merge queue Sep 13, 2023
Merged via the queue into develop with commit 94903ae Sep 13, 2023
4 checks passed
@mcdonnnj mcdonnnj deleted the maintenance/update_pre-commit_hooks branch September 13, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

Assignees

@mcdonnnj mcdonnnj

Labels
dependencies Pull requests that update a dependency file kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dav3r