Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate pushing [u]int/float64 to output plugins #15

Open
remingtonc opened this issue May 18, 2019 · 0 comments
Open

Evaluate pushing [u]int/float64 to output plugins #15

remingtonc opened this issue May 18, 2019 · 0 comments

Comments

@remingtonc
Copy link
Contributor

remingtonc commented May 18, 2019

Per #6 we replicate/customize (was originally a patch) jsonpb which emits uint64 values as strings to instead make them uint64s. It appears this was largely done to maintain correctness with JavaScript alongside some JSON specification language so this is a fine workaround, however if we can easily push that deserialization functionality to the outputs it would probably be a better solution and explicitly acknowledge the intended functionality of jsonpb.

@remingtonc remingtonc added the enhancement New feature or request label May 18, 2019
@remingtonc remingtonc added feature refactor and removed enhancement New feature or request labels May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant