update deprecated github actions (#544)

* update deprecated github actions

* fix type error

Author: sbasan

.github/workflows/documentation.yml

@@ -6,9 +6,9 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - name: Set up Python
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@v5
       with:
         python-version: 3.8
     - name: Set Up Poetry
@@ -20,7 +20,7 @@ jobs:
     - name: Build HTML
       run: poetry run sphinx-build -M html docs/source docs/build
     - name: Upload artifacts
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: html-docs
         path: docs/build/html/

.github/workflows/linting.yml

@@ -19,9 +19,9 @@ jobs:
         run: |
             curl -fsSL https://deb.nodesource.com/setup_12.x | sudo -E bash -
             sudo apt-get install -y nodejs
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
       - name: Set Up Poetry

.github/workflows/release.yml

@@ -17,9 +17,9 @@ jobs:
         run: |
           curl -fsSL https://deb.nodesource.com/setup_12.x | sudo -E bash -
           sudo apt-get install -y nodejs
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: 3.8
       - name: Set Up Poetry

.github/workflows/unittests.yml

@@ -19,9 +19,9 @@ jobs:
         run: |
             curl -fsSL https://deb.nodesource.com/setup_12.x | sudo -E bash -
             sudo apt-get install -y nodejs
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
       - name: Set Up Poetry

.github/workflows/version.yml

@@ -12,9 +12,9 @@ jobs:
         shell: bash
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: 3.8
       - name: Set Up Poetry

catalystwan/session.py

@@ -259,7 +259,8 @@ def login(self) -> ManagerSession:
         self.logger.info(
             f"Logged to vManage({self.platform_version}) as {self.username}. The session type is {self.session_type}"
         )
-        self.cookies.set("JSESSIONID", self.auth.set_cookie.get("JSESSIONID"))
+        if jsessionid := self.auth.set_cookie.get("JSESSIONID"):
+            self.cookies.set("JSESSIONID", jsessionid)
         return self
 
     def wait_server_ready(self, timeout: int, poll_period: int = 10) -> None: