refactor: replace dockerhub images for public.ecr.aws (#61)

* refactor: replace dockerhub images for public.ecr.aws

* fix: remove depends_on to prevent destroying the actual policy

* fix: prevent race condition to deploy zoombie runner cleanup

Author: edersonbrilhante

modules/core/arc/scale_set/template_files/dind.yml.tftpl

@@ -37,7 +37,7 @@ template:
 
       - name: init-dind-rootless
         imagePullPolicy: Always
-        image: docker:dind-rootless
+        image: public.ecr.aws/docker/library/docker:dind-rootless
         command:
           - sh
           - -c
@@ -127,7 +127,7 @@ template:
             memory: ${container_requests_memory}
 
       - name: dind
-        image: docker:dind-rootless
+        image: public.ecr.aws/docker/library/docker:dind-rootless
         imagePullPolicy: Always
         args: ["dockerd", "--host=unix:///home/runner/var/run/docker.sock"]
         securityContext:
@@ -157,7 +157,7 @@ template:
             memory: ${container_requests_memory}
 
       - name: runner-logs
-        image: busybox
+        image: public.ecr.aws/docker/library/busybox:stable
         command:
           - sh
           - -c
@@ -184,7 +184,7 @@ template:
             memory: "64Mi"
 
       - name: hook
-        image: busybox
+        image: public.ecr.aws/docker/library/busybox:stable
         command:
           - sh
           - -c

modules/core/arc/scale_set/template_files/k8s.yml.tftpl

@@ -69,7 +69,7 @@ template:
             memory: ${container_requests_memory}
 
       - name: runner-logs
-        image: busybox
+        image: public.ecr.aws/docker/library/busybox:stable
         command:
           - sh
           - -c
@@ -96,7 +96,7 @@ template:
             memory: "64Mi"
 
       - name: hook
-        image: busybox
+        image: public.ecr.aws/docker/library/busybox:stable
         command:
           - sh
           - -c

modules/core/arc/zoombie.tf

@@ -4,6 +4,11 @@ resource "kubernetes_service_account_v1" "zombie_runner_cleanup" {
     name      = "zombie-runner-cleanup"
     namespace = var.controller_config.namespace
   }
+
+  depends_on = [
+    module.controller,
+    module.scale_sets
+  ]
 }
 
 resource "kubernetes_role_v1" "zombie_runner_cleanup" {
@@ -24,6 +29,11 @@ resource "kubernetes_role_v1" "zombie_runner_cleanup" {
     resources  = ["ephemeralrunners"]
     verbs      = ["get", "list", "delete", "watch"]
   }
+
+  depends_on = [
+    module.controller,
+    module.scale_sets
+  ]
 }
 
 resource "kubernetes_role_binding_v1" "zombie_runner_cleanup" {
@@ -44,6 +54,11 @@ resource "kubernetes_role_binding_v1" "zombie_runner_cleanup" {
     kind      = "Role"
     name      = kubernetes_role_v1.zombie_runner_cleanup[0].metadata[0].name
   }
+
+  depends_on = [
+    module.controller,
+    module.scale_sets
+  ]
 }
 
 resource "kubernetes_cron_job_v1" "zombie_runner_cleanup" {
@@ -90,4 +105,9 @@ resource "kubernetes_cron_job_v1" "zombie_runner_cleanup" {
       }
     }
   }
+
+  depends_on = [
+    module.controller,
+    module.scale_sets
+  ]
 }

modules/infra/eks/nodes.tf

@@ -57,6 +57,5 @@ module "self_managed_node_group" {
 
   depends_on = [
     time_sleep.wait_300_seconds,
-    null_resource.create_calico_installation
   ]
 }