Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build support for gcc-11, gcc-12 and gcc-13 #1087

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bjosv
Copy link

@bjosv bjosv commented Dec 19, 2023

Handle build-warning errors by disabling some warnings found by the new compiler versions.
Additionally fix a new overloaded-virtual warning found by gcc-13.

The issues can be found in logs on local CI-runs:
gcc-11 maybe-uninitialized warning:
https://github.com/Nordix/trex-core/actions/runs/7259509593/job/19776795795

gcc-12 dangling pointer warning:
https://github.com/Nordix/trex-core/actions/runs/7259509593/job/19776796061

Run with similar corrections, which are ok:
https://github.com/Nordix/trex-core/actions/runs/7267842399

Handle build warning errors by disabling some warnings found by the
new compiler versions.

Signed-off-by: Björn Svensson <[email protected]>
@trex-bot
Copy link

Checked SHA: 3cc26aa
Status: FAILURE
Link to job: http://81.218.86.50:8080/job/trex_build/812/

@bjosv
Copy link
Author

bjosv commented Dec 20, 2023

The Jenkins job fail while generating some kind of HTML report:
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 1480: ordinal not in range(128)

I cant see what it does, but speculating that its because of the character ö in my name..

@bjosv
Copy link
Author

bjosv commented Dec 20, 2023

Updating the xmls2html.py script with error replacement could help:

>>> b"\xc3".decode("ascii")
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 0: ordinal not in range(128)

>>> b"\xc3".decode("ascii", errors="replace")
'�'

@bjosv
Copy link
Author

bjosv commented Jan 15, 2024

What is your recommendation @hhaim, should I update the commits in this PR so there are no non-ascii characters?

@hhaim
Copy link
Contributor

hhaim commented Feb 25, 2024

recheck

@trex-bot
Copy link

Checked SHA: 3cc26aa
Status: FAILURE
Link to job: http://81.218.86.50:8080/job/trex_build/821/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants