Fix sanitizer errors in testcases #1096
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests uses `tpg_header` when validating the statistics while its memory `m1` has been freed. `tmp_buf` is not used in tests but is now correct in size. Signed-off-by: Björn Svensson <[email protected]>
Fixed a couple of testcases that triggered errors by the leak sanitizer. All issues are due to missing actions in the testcases. There are still 2 testcase left that are expected to leak: gt_astf_inter.astf_negative_2 gt_astf_inter.astf_negative_3 so testruns needs to filter out these using: ./bp-sim-64 --ut --gtest_filter='-*.astf_negative*' Signed-off-by: Björn Svensson <[email protected]>
|
Checked SHA: c5fb3ee |
|
recheck |
|
Checked SHA: c5fb3ee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the heap-use-after-free issues in TPGRxStatsTest.
The tests uses
tpg_headerwhen validating the statistics while its memorym1has been freed.tmp_bufis not used in tests but is now correct in size.Fixed direct and indirect leaks in tests
Fixed a couple of testcases that triggered errors by the leak sanitizer.
All issues are due to missing actions in the testcases.
There are still 2 testcase left that are expected to leak for some reason:
while negative_4 and negative_5 are commented away in legacy. Maybe we should remove all of them?
The flows are already covered by other testcases, except they perform proper cleanup.
Currently we need to filter out these negative testruns when using memory analysis tools:
./bp-sim-64 --ut --gtest_filter='-*.astf_negative*'