You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This line will cause a crash when using stunlib with a NULLstream argument. i.e. stunlib_DecodeMessage(buff, bufLen, &msg, NULL, NULL). Pretty much everywhere in stunlib_DecodeMessage is guarding on stream != NULL) before calling printError, but in the case of an invalid crc, it does not.
I would suggest moving the NULL guard into printError to be less error prone and fix this use case.
The text was updated successfully, but these errors were encountered:
This line will cause a crash when using stunlib with a
NULL
stream
argument. i.e.stunlib_DecodeMessage(buff, bufLen, &msg, NULL, NULL)
. Pretty much everywhere instunlib_DecodeMessage
is guarding onstream != NULL
) before callingprintError
, but in the case of an invalid crc, it does not.I would suggest moving the
NULL
guard intoprintError
to be less error prone and fix this use case.The text was updated successfully, but these errors were encountered: