New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not validated against ioctl return value #272

Open

devendranaga opened this issue Jun 27, 2019 · 0 comments

devendranaga commented Jun 27, 2019

this could result in a potential uninitalized memory access down the line.

Line 289 in 47afb19

ioctl(sock, SIOCGIFHWADDR, &ifr);

The code below ioctl is :

	sprintf((char*)mac_addr, "%02x%02x%02x%02x%02x%02x",
		(int)(unsigned char)ifr.ifr_hwaddr.sa_data[0],
		(int)(unsigned char)ifr.ifr_hwaddr.sa_data[1],
		(int)(unsigned char)ifr.ifr_hwaddr.sa_data[2],
		(int)(unsigned char)ifr.ifr_hwaddr.sa_data[3],
		(int)(unsigned char)ifr.ifr_hwaddr.sa_data[4],
(int)(unsigned char)ifr.ifr_hwaddr.sa_data[5]);

And the get_mac_address OS specific code could be refactored into small functions as well.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment