Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Proposal caching from State #414

Open
bifurcation opened this issue Dec 7, 2023 · 0 comments
Open

Remove Proposal caching from State #414

bifurcation opened this issue Dec 7, 2023 · 0 comments

Comments

@bifurcation
Copy link
Contributor

Right now, calling State::handle() with a Proposal validates the proposal and adds it to a queue internal to the State object. This is problematic for a couple of reasons. It means that the State object has to be mutable. And it reduces the application's control over what proposals are committed, since the application can't remove a proposal once it has been enqueued.

A better approach would be to have the application be in charge of managing the proposal queue directly, with State providing the tools to (1) validate proposals before caching and (2) commit a list of proposals.

We have actually already started down this path. #412 provides State::unwrap() to validate a proposal without enqueuing it, and a variant of State::handle() to explicitly enqueue a proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant