Terms "collection-number" and "number" are missing

[denismaier]

I don't remember if that was on purpose or an oversight, but looks like the term for collection-number is missing. Any objections if I add it?

@adam3smith @bwiernik

[adam3smith]

No objections; I'd assume this was an oversight

[denismaier]

Ok, I'll add it. Just a question: Do we have a way to add to it all locales where the term is missing? IIRC, @zepinglee had something like this.

[bwiernik]

I've just done it manually in the past

[zepinglee]

Previously I wrote a script to resolve duplicate terms in all locale files (#269). It was relatively easy so I split each locales-*.xml file into lines and made some modifications. However adding missing terms is not trivial and special care must be taken. First, some terms are missing because they are identical to their default "long" forms. For example, in locales-nn-NO.xml the <term name="no-place" form="short"> is missing and we cannot copy the one from locales-en-US.xml.

locales/locales-nn-NO.xml

Lines 27 to 29 in a7c6f63

	<term name="loc-cit">loc. cit.</term> <!-- like ibid., the abbreviated form is the regular form -->
	<term name="no-place">manglar stad</term>
	<term name="no-publisher">manglar utgjevar</term> <!-- sine nomine -->

locales/locales-en-US.xml

Lines 39 to 42 in a7c6f63

	<term name="loc-cit">loc. cit.</term> <!-- like ibid., the abbreviated form is the regular form -->
	<term name="no-place">no place</term>
	<term name="no-place" form="short">n.p.</term>
	<term name="no-publisher">no publisher</term> <!-- sine nomine -->

Secondly, in some edge cases the position of copied terms is not as expected. This is similar to git merge which may have conflicts.

I've written a script https://gist.github.com/zepinglee/e6d0076a89b0266c9c9886fd83aacd99 and it should work in most cases.

[bwiernik]

I open up VS Code, select the line before the one I want to add, then use find-and-replace to replace that line with two lines (the existing one and the new one). I then click on each file in the left sidebard and click the replace all button for each. Takes about 4 minutes to update all the locales.

[bwiernik]

I noticed that "number" is also missing. We should double check that all of the number variables are correctly listed.