Recent changes in the en_US locale break several tests in the CSL test suite

[andras-simonyi]

Dear All, I've just noticed that commit #298 (Add missing terms to en-US and alphabetize) seems to break a significant number (~30) of tests in the CSL test suite on citeproc-el, because many used styles rely on some terms not being available, most notably the author verb role form. (I've not yet tried to run those tests on other processors, but I expect them to be broken on other conformant implementations too.) Are there any plans to update the tests in question (and perhaps styles that also became problematic) to make them compatible with the locale changes?

[bwiernik]

Can you link to the tests that are failing? I'm not quite following the context wherein a verb role form would be needed but prohibited for the author role.

[andras-simonyi]

Thanks for the prompt response -- on closer inspection it looks like the problem must be on the citeproc-el side, apologies for the noise. (I'm closing the ticket.)

[bwiernik]

Let us know if you notice any additional issues

[zepinglee]

There are 43 failed tests in citeproc-js with updated locales (see zepinglee/citeproc-js/actions/runs/8198951140 and expand the "cslrun -a --reporter spec" step). 6 of them are in the standard test-suite.

@andras-simonyi I suggest checking out the 6b0cb46 commit of locales for testing purpose which is used in current citeproc-js.

[andras-simonyi]

@zepinglee thanks, meanwhile I've found and fixed a bug in citeproc-el's term lookup code but the following CSL suite tests are still failing, seemingly because of the changes, both in citeproc-el and citeproc-js:

• fullstyles-chicago-article-title-question
• sort-chicago-year-suffix1
• sort-chicago-year-suffix2

One of the reasons seems to be that the "contributors" macro in the Chicago versions used in the tests contains

<label form="verb-short" prefix=", " suffix="." text-case="lowercase" />

which is now rendered as "by" for the author variable instead of the earlier empty rendering.

[bwiernik]

I've fixed those tests and they should pass now. (For the case of the Chicago style tests, they were incorrectly using verb-short when they should have been using short).

Thanks for the report folks!