Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant load resource file with the manifest #1485

Closed
KiLaF opened this issue Jun 11, 2022 · 6 comments
Closed

Cant load resource file with the manifest #1485

KiLaF opened this issue Jun 11, 2022 · 6 comments
Labels
stale Issue or PR has remained open with no activity and has become stale.

Comments

@KiLaF
Copy link

KiLaF commented Jun 11, 2022

So when you try to load a resource file from the manifest using the @ it dont work

Exemple:
client_script '@RESOURCE-NAME/FILE-NAME.lua'

please fix this !

@AvarianKnight
Copy link
Contributor

No reproduction steps at all? Other resources use this perfectly fine without any issue (like oxmysql & mysql)

@Disquse
Copy link
Contributor

Disquse commented Jun 11, 2022

Your report is incomplete/invalid. As @AvarianKnight said, it works as expected, just tested myself.

@gottfriedleibniz
Copy link
Contributor

gottfriedleibniz commented Jun 11, 2022

Given the lack of information and making some leaps in logic:

Should https://github.com/citizenfx/fivem/blob/master/code/components/citizen-server-impl/src/ServerResources.cpp#L88 (fragRef) include a skyr::percent_decode? (Similarly on client, although, in a few more spots)

@5m1Ly
Copy link

5m1Ly commented Aug 23, 2022

So when you try to load a resource file from the manifest using the @ it dont work

Exemple: client_script '@RESOURCE-NAME/FILE-NAME.lua'

please fix this !

So my question is, did you load client_script 'file.lua' within the resource that you load it from because on the server side you can load server files within other resources without having to load them within the resource it self. how ever on the client side this is a diffrent story.

so lets say you got resource_a and resource_b and you want to load a file of resource_b within resource_a then you need to load resource_b before resource_a and you need to load the file on the client side at resource_a and resource_b. I'm not sure because i didn't test it any furter then this but i believe that its also not posible to load it shared on one of both sides you need to load it separetly.

With that being said,

server.cfg

ensure resource_b
ensure resource_a

resource_b/fxmanifest.lua

client_script 'client.lua'

resource_a/fxmanifest.lua

client_script '@resource_b/client.lua'

@5m1Ly
Copy link

5m1Ly commented Aug 26, 2022

So i tested it and it also works shared, but then again you need to load it bought at the resources the file originates from and the resource where you want load the file.

@gottfriedleibniz gottfriedleibniz added the stale Issue or PR has remained open with no activity and has become stale. label Feb 11, 2024
@gottfriedleibniz
Copy link
Contributor

Marking as stale. If still an issue, please reopen.

@gottfriedleibniz gottfriedleibniz closed this as not planned Won't fix, can't repro, duplicate, stale Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants