Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase total asset limit for pgRawStreamer beyond 65535 #2984

Open
Legacy-TacticalGamingInteractive opened this issue Dec 6, 2024 · 7 comments
Labels
bug crash triage Needs a preliminary assessment to determine the urgency and required action

Comments

@Legacy-TacticalGamingInteractive
Copy link

Legacy-TacticalGamingInteractive commented Dec 6, 2024

What happened?

Increase total asset limit for pgRawStreamer beyond 65535

Does anyone on the FiveM team here know if this is still something in the future plans to get worked on?

A few months back some guys from the team were talking about it, as several servers have been hitting the limit. At that time we created the error that at least now shows clients when that limit is reached upon attempting to join a server that has reached the limit. Additionally one can check the limit with assetscount in console.

I am aware its no easy update so I'm told. However I am just wondering if it is still on the backlog of things for the future to improve FiveM.

We continually hits this limit and its difficult to simply remove stuff (especially awesome stuff you bought and love) from the server. Especially when everyone complains when stuff gets removed - yet also constantly wants new stuff. Understandably though, nobody wants to lose content of course. Now we are no longer really able to buy anything else on Tebex as much as we want to, as there is no point since the server is basically maxed out!

Thank you!

EDIT:
I just saw this old commit by @blattersturm, while outdated possibly now, this commit, if refactored in some form - is it still viable?
e5903ed

Expected result

Increased pgRawStreamer limit

Reproduction steps

Have a server streaming assets beyond the limit.

Importancy

Crash

Area(s)

FiveM, FXServer

Specific version(s)

tx: v7.3.2 | fx: b11840 | gta build 3258

Additional information

It would be a great service to the FiveM community. The ability to buy more content for servers and expand beyond the limit of streamed assets currently there would be incredible.

@Legacy-TacticalGamingInteractive Legacy-TacticalGamingInteractive added bug triage Needs a preliminary assessment to determine the urgency and required action labels Dec 6, 2024
@github-actions github-actions bot added the crash label Dec 6, 2024
@ImBaphomettt
Copy link

Hello, I am experiencing the same issue. Indeed, it would be beneficial for some people to have this modification, especially with the increase in pool size, which now allows us to do more.

@Gltch3d
Copy link

Gltch3d commented Dec 9, 2024

I seems the ability to increase pool limits was somewhat counter intuitive. Correct me if I am wrong here but doing so doesn't increase the overall pgRawStreamer limit does it? That would likely further allow the issue to become a bigger one. The only real solution right now is to find any heavy resources having the most impact on your servers pgRawStreamer limit and remove it. I know it isnt the solution anyone is really wanting, but will be the only option until an update of some kind is considered if ever.

@ook3D
Copy link
Contributor

ook3D commented Dec 9, 2024

I seems the ability to increase pool limits was somewhat counter intuitive. Correct me if I am wrong here but doing so doesn't increase the overall pgRawStreamer limit does it? That would likely further allow the issue to become a bigger one. The only real solution right now is to find any heavy resources having the most impact on your servers pgRawStreamer limit and remove it. I know it isnt the solution anyone is really wanting, but will be the only option until an update of some kind is considered if ever.

How is the pool limit feature even relevant here, it's a completely different unrelated issue

@Gltch3d
Copy link

Gltch3d commented Dec 9, 2024

I seems the ability to increase pool limits was somewhat counter intuitive. Correct me if I am wrong here but doing so doesn't increase the overall pgRawStreamer limit does it? That would likely further allow the issue to become a bigger one. The only real solution right now is to find any heavy resources having the most impact on your servers pgRawStreamer limit and remove it. I know it isnt the solution anyone is really wanting, but will be the only option until an update of some kind is considered if ever.

How is the pool limit feature even relevant here, it's a completely different unrelated issue

What exactly are you talking about? The ability to increase pool size (which was added in a PR some time ago) allows you to increase the limit of specific asset types you can stream does it not? This would inherently allow someone add more txd as an example to the server only furthering the potential of reaching the overall pgRawStreamer limit.

@ook3D
Copy link
Contributor

ook3D commented Dec 9, 2024

I seems the ability to increase pool limits was somewhat counter intuitive. Correct me if I am wrong here but doing so doesn't increase the overall pgRawStreamer limit does it? That would likely further allow the issue to become a bigger one. The only real solution right now is to find any heavy resources having the most impact on your servers pgRawStreamer limit and remove it. I know it isnt the solution anyone is really wanting, but will be the only option until an update of some kind is considered if ever.

How is the pool limit feature even relevant here, it's a completely different unrelated issue

What exactly are you talking about? The ability to increase pool size (which was added in a PR some time ago) allows you to increase the limit of specific asset types you can stream does it not? This would inherently allow someone add more txd as an example to the server only furthering the potential of reaching the overall pgRawStreamer limit.

No not necessarily, pools are not only related to streamed assets, you can reach the streamer limit without any pool increases

@Gltch3d
Copy link

Gltch3d commented Dec 9, 2024

I seems the ability to increase pool limits was somewhat counter intuitive. Correct me if I am wrong here but doing so doesn't increase the overall pgRawStreamer limit does it? That would likely further allow the issue to become a bigger one. The only real solution right now is to find any heavy resources having the most impact on your servers pgRawStreamer limit and remove it. I know it isnt the solution anyone is really wanting, but will be the only option until an update of some kind is considered if ever.

How is the pool limit feature even relevant here, it's a completely different unrelated issue

What exactly are you talking about? The ability to increase pool size (which was added in a PR some time ago) allows you to increase the limit of specific asset types you can stream does it not? This would inherently allow someone add more txd as an example to the server only furthering the potential of reaching the overall pgRawStreamer limit.

No not necessarily, pools are not only related to streamed assets, you can reach the streamer limit without any pool increases

Okay, that makes a little more sense. Thanks for the clarification.

@Legacy-TacticalGamingInteractive
Copy link
Author

There is a max limit of all ydr, ytyp, ybn, ytd, ymt etc that can be streamed to clients. Unfortunately this causes issues on many servers especially long running servers who invest heavily in content from Tebex etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug crash triage Needs a preliminary assessment to determine the urgency and required action
Projects
None yet
Development

No branches or pull requests

4 participants