Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Azure/azure-sdk-for-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: citusdata/azure-sdk-for-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Feb 7, 2022

  1. azblob: fix ListBlob to preserve prefix while paging

    Philip Dubé committed Feb 7, 2022
    Copy the full SHA
    cb43101 View commit details
Showing with 5 additions and 7 deletions.
  1. +4 −6 sdk/storage/azblob/zc_container_client.go
  2. +1 −1 sdk/storage/azblob/zc_service_client.go
10 changes: 4 additions & 6 deletions sdk/storage/azblob/zc_container_client.go
Original file line number Diff line number Diff line change
@@ -187,9 +187,8 @@ func (c ContainerClient) ListBlobsFlat(listOptions *ContainerListBlobFlatSegment

// override the advancer
pager.advancer = func(ctx context.Context, response ContainerListBlobFlatSegmentResponse) (*policy.Request, error) {
return c.client.listBlobFlatSegmentCreateRequest(ctx, &ContainerListBlobFlatSegmentOptions{
Marker: response.NextMarker,
})
listOptions.Marker = response.NextMarker
return c.client.listBlobFlatSegmentCreateRequest(ctx, listOptions)
}

// TODO: Come Here
@@ -217,9 +216,8 @@ func (c ContainerClient) ListBlobsHierarchy(delimiter string, listOptions *Conta

// override the advancer
pager.advancer = func(ctx context.Context, response ContainerListBlobHierarchySegmentResponse) (*policy.Request, error) {
return c.client.listBlobHierarchySegmentCreateRequest(ctx, delimiter, &ContainerListBlobHierarchySegmentOptions{
Marker: response.NextMarker,
})
listOptions.Marker = response.NextMarker
return c.client.listBlobHierarchySegmentCreateRequest(ctx, delimiter, listOptions)
}

// todo: come here
2 changes: 1 addition & 1 deletion sdk/storage/azblob/zc_service_client.go
Original file line number Diff line number Diff line change
@@ -252,7 +252,7 @@ func (s ServiceClient) GetSASToken(resources AccountSASResourceTypes, permission
// eg. "dog='germanshepherd' and penguin='emperorpenguin'"
// To specify a container, eg. "@container=’containerName’ and Name = ‘C’"
func (s ServiceClient) FindBlobsByTags(ctx context.Context, options ServiceFilterBlobsByTagsOptions) (ServiceFilterBlobsResponse, error) {
// TODO: Use pager here? Missing support from zz_generated_pagera.go
// TODO: Use pager here? Missing support from zz_generated_pagers.go
serviceFilterBlobsOptions := options.pointer()
return s.client.FilterBlobs(ctx, serviceFilterBlobsOptions)
}