Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Create extension if not exists" fails on Citus workers #7091

Open
thamerlan opened this issue Jul 31, 2023 · 1 comment · May be fixed by #7641
Open

"Create extension if not exists" fails on Citus workers #7091

thamerlan opened this issue Jul 31, 2023 · 1 comment · May be fixed by #7641
Labels
bug

Comments

@thamerlan
Copy link

If non-power user tries to create extension with "IF NOT EXISTS" - DB with Citus generates exception:

must be owner of extension uuid-ossp

even if extension already exists.

Vanilla PostgreSQL allows such operation (just ignores).

Example
Citus:

[myuser@mydb]SQL=> CREATE EXTENSION IF NOT EXISTS "uuid-ossp" SCHEMA public;
ERROR:  must be owner of extension uuid-ossp
CONTEXT:  while executing command on my_worker_host:my_worker_port

Logs on worker:

<2023-07-31 14:00:43 UTC> [app:citus_internal gpid=10000005497] ERROR:  must be owner of extension uuid-ossp
<2023-07-31 14:00:43 UTC> [app:citus_internal gpid=10000005497] STATEMENT:  
WITH distributed_object_data(typetext, objnames, objargs, distargumentindex, colocationid, force_delegation)  AS (VALUES ('extension', ARRAY['uuid-ossp']::text[], ARRAY[]::text[], -1, 0, false)) SELECT citus_internal_add_object_metadata(typetext, objnames, objargs, distargumentindex::int, colocationid::int, force_delegation::bool) FROM distributed_object_data;

Vanilla PostgreSQL:

[myuser@mydb]SQL=> CREATE EXTENSION IF NOT EXISTS "uuid-ossp" SCHEMA public;
CREATE EXTENSION
Time: 0.653 ms

Environment:
PostgreSQL : (14.8 (Ubuntu 14.8-1.pgdg18.04+1)
Citus: 11.3-1
@mulander mulander added the bug label Jun 13, 2024
@mulander
Copy link
Contributor

I reproduced this locally with Citus 12.1.4 and Postgres 16.3. This indeed is a bug in Citus.

awolk=> create extension if not exists "uuid-ossp";
NOTICE:  extension "uuid-ossp" already exists, skipping
NOTICE:  issuing BEGIN TRANSACTION ISOLATION LEVEL READ COMMITTED;SELECT assign_distributed_transaction_id(0, 11, '2024-06-13 12:13:03.915846+02');
DETAIL:  on server a_user@localhost:9701 connectionId: 1
NOTICE:  issuing SET citus.enable_ddl_propagation TO 'off'
DETAIL:  on server a_user@localhost:9701 connectionId: 1
NOTICE:  issuing CREATE EXTENSION IF NOT EXISTS "uuid-ossp" WITH SCHEMA  public;
DETAIL:  on server a_user@localhost:9701 connectionId: 1
NOTICE:  issuing SET citus.enable_ddl_propagation TO 'on'
DETAIL:  on server a_user@localhost:9701 connectionId: 1
NOTICE:  issuing BEGIN TRANSACTION ISOLATION LEVEL READ COMMITTED;SELECT assign_distributed_transaction_id(0, 11, '2024-06-13 12:13:03.915846+02');
DETAIL:  on server a_user@localhost:9702 connectionId: 3
NOTICE:  issuing SET citus.enable_ddl_propagation TO 'off'
DETAIL:  on server a_user@localhost:9702 connectionId: 3
NOTICE:  issuing CREATE EXTENSION IF NOT EXISTS "uuid-ossp" WITH SCHEMA  public;
DETAIL:  on server a_user@localhost:9702 connectionId: 3
NOTICE:  issuing SET citus.enable_ddl_propagation TO 'on'
DETAIL:  on server a_user@localhost:9702 connectionId: 3
NOTICE:  issuing WITH distributed_object_data(typetext, objnames, objargs, distargumentindex, colocationid, force_delegation)  AS (VALUES ('extension', ARRAY['uuid-ossp']::text[], ARRAY[]::text[], -1, 0, false)) SELECT citus_internal_add_object_metadata(typetext, objnames, objargs, distargumentindex::int, colocationid::int, force_delegation::bool) FROM distributed_object_data;
DETAIL:  on server a_user@localhost:9701 connectionId: 1
NOTICE:  issuing WITH distributed_object_data(typetext, objnames, objargs, distargumentindex, colocationid, force_delegation)  AS (VALUES ('extension', ARRAY['uuid-ossp']::text[], ARRAY[]::text[], -1, 0, false)) SELECT citus_internal_add_object_metadata(typetext, objnames, objargs, distargumentindex::int, colocationid::int, force_delegation::bool) FROM distributed_object_data;
DETAIL:  on server a_user@localhost:9702 connectionId: 3
ERROR:  must be owner of extension uuid-ossp
CONTEXT:  while executing command on localhost:9701
NOTICE:  issuing ROLLBACK
DETAIL:  on server a_user@localhost:9701 connectionId: 1
awolk=>

@copetol copetol linked a pull request Jul 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #7091 issue copetol/citus
2 participants
@mulander @thamerlan