Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial status value #21

Open
SaitTalhaNisanci opened this issue Sep 16, 2019 · 0 comments
Open

Initial status value #21

SaitTalhaNisanci opened this issue Sep 16, 2019 · 0 comments

Comments

@SaitTalhaNisanci
Copy link
Contributor

Currently we have a structure like this in our scripts:

status = 0
# run the test and assign the exit code to status
exit(status)

Wouldnt it be better to start with a nonzero status code so that if we dont run our tests the script will return with a nonzero code? Currently if the tests are not run the initial status which is 0 will be returned.

An example can be seen here:
https://github.com/citusdata/the-process/blob/upgradeTester/circleci/images/exttester/files/sbin/install-and-test-ext#L15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant