Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated kubernetes create and kubernetes remove commands #510

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kanha-gupta
Copy link
Contributor

@kanha-gupta kanha-gupta commented Feb 8, 2025

Fixes #496

PR Summary -

  1. Removes --merge and --switch flags. just --save works fine now and fulfills the requirements as mentioned in the issue
  2. kubeconfig overwrites have been taken cared of along with making --wait flag implicit while using --save flag
  3. Added flag to clear up kubeconfig file for the server that is being deleted. the flag naming is --remove for now. currently it notifies the user if the cluster being deleted is also the current-context so that user performs the needful without any facing any errors.
  4. Issue mentioned the need for civo kubernetes update-kubeconfig but I see similar functionality already implemented - civo kubernetes config command. Open to discussion
  5. Updated documentation in readme
    Demo ->
    Screenshot from 2025-02-08 11-40-16

Screenshot from 2025-02-08 11-47-31

@kanha-gupta
Copy link
Contributor Author

@fernando-villalba @uzaxirr please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing the way that Civo CLI handles kubeconfig
1 participant