feat: upgrade Android Auth library to 2.0.2 #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome thanks for the PR! sorry for the delay, I've been underwater at work. |
|
Hi @cjam, no worries I know exactly how it feels :) I've managed to move this PR forward a little testing-wise and there's still some more work to be done on it, Spotify's changed a few things in the move from v1 -> v2 of the auth sdk that I'm trying to integrate properly. I've also taken this comment (#203) into consideration and changed how the auth-sdk is imported, as it's the only way to get v2.0.2. I should probably mark this PR as WIP until I've got it sorted really. |
wwdrew
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #209 .
Changes introduced in this pull request:
Tasks
yarn contributeUnreleasedsection ofCHANGELOG.mdwith changes (Convention)@cjam
Please note I'm having problems testing this change so there's a high chance it doesn't work. However, everything in Android Studio is saying it's okay so I'm hopeful it should work. I just couldn't get a package to build I could import into my project to make sure.