-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SQL Support #230
Comments
Is there a way to transition my data from database to localstorage? Alhough i must admit im kinda suspicious on what you are doing if accesing a database is slower than using files. |
Hopefully with 0.0.24 you shouldn't have to do anything, and it wasn't really slower to use the database system after I added the same data system behind both methods of saving (I guess the issue text is outdated). The reason I don't think we need it anymore is that it takes a lot of code to maintain and minor changes to format require extra layers of conversion code to ensure everything works smoothly. The newer method of saving will be file-based and be separated by region, similar to chunk data in the world folder, which I hope doesn't cause too many issues 😬 Is there a specific use case where having the data in a database would be better? I just feel like the kind of information we store doesn't necessarily need it (and there is a chance it hasn't been updated properly and I miss it, as I don't use the setting anywhere myself) |
We need to remove SQL support, it adds no functionality that storage on disk doesn't, only making it more of a chore to retrieve information. Remove the
database
section in the config, if it's enabled, retrieve all the information first and save it in JSON. Make sure to make this very transparent to the user!The text was updated successfully, but these errors were encountered: