Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty multiple_checkbox is not saved #387

Open
frafra opened this issue Sep 24, 2023 · 0 comments · May be fixed by #388
Open

Empty multiple_checkbox is not saved #387

frafra opened this issue Sep 24, 2023 · 0 comments · May be fixed by #388

Comments

@frafra
Copy link

frafra commented Sep 24, 2023 •
edited
Loading

Hi! :)
In certain cases, changes to a multiple_checkbox are not saved.

How to reproduce:

  1. Create a schema with a multiple_checkbox
  2. Create a dataset and check some boxes
  3. Edit the dataset and uncheck all the boxes

The last action has no effect. This happens because the /edit/ endpoint calls package_patch instead of package_update.

ckanext-scheming/ckanext/scheming/views.py

Line 184 in 8646a9d

complete_data = get_action('package_patch')(None, data_dict)

Since package_patch has to be used, since multiple start_form_page can be specified, a reasonable fix would be to have the browser send the entire form, including an empty list for each of the empty multiple_checkbox.
@frafra frafra linked a pull request Sep 24, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle empty multiple_checkbox frafra/ckanext-scheming
1 participant
@frafra