Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum dataset max limitation that a showcase can hold #145

Open
quinoescobar opened this issue May 25, 2022 · 0 comments · May be fixed by #147
Open

Maximum dataset max limitation that a showcase can hold #145

quinoescobar opened this issue May 25, 2022 · 0 comments · May be fixed by #147
Assignees

Comments

@quinoescobar
Copy link

Version
CKAN 2.9.3; Showcase 1.4.8

Describe the bug
Trying to create a showcase with around +1600 datasets

  • Create a Showcase

  • Add >= 1100 datasets to it

  • Navigate to the /showcase page e.g.: www.yourdom.com/ckanhome/showcase

  • You will see an error and the none showcase are shown

Expected behavior

  • Creating a showcase with more than >= 1041 datasets is shown correctly and paginate it

Additional details

The error with a showcase with more than 1041 datasets is cause but the huge boolean clause generated by this : https://github.com/ckan/ckanext-showcase/blob/master/ckanext/showcase/logic/action/get.py#L118

It can be easily change the maximum number of clauses allowed with the query by changing the maxBooleanClauses property (https://solr.apache.org/guide/6_6/query-settings-in-solrconfig.html#maxbooleanclauses) but I reckon its better to modify the query's logic per se and modify the templates to allow the pagination.

Though the showcase can hold up to 1000 datasets without problem, It's only shown 100. This is hardcoded here https://github.com/ckan/ckanext-showcase/blob/master/ckanext/showcase/logic/action/get.py#L121

@bellisk bellisk self-assigned this Aug 10, 2022
@bellisk bellisk linked a pull request Aug 10, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants