Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with url_for and /showcases redirect #33

Open
torfsen opened this issue Apr 25, 2016 · 0 comments
Open

Problem with url_for and /showcases redirect #33

torfsen opened this issue Apr 25, 2016 · 0 comments

Comments

@torfsen
Copy link
Contributor

torfsen commented Apr 25, 2016

I am dynamically constructing links for listing showcases by tag:

<a href="{% url_for controller='showcase', action='search', tags=tag.name %}">{{ h.truncate(tag.display_name, 22) }}</a>

The url_for call returns an URL for /showcases (trailing s):

http://localhost:5000/showcases?tags=interaktiv

That URL is then redirected to /showcase (no trailing s), but the query parameters are lost:

ckanext_showcase_redirect_bug

Either the redirect should also forward the query parameters or url_for should return the correct URL. What's the rational behind having both /showcase and /showcases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant