Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No support for page anchors #25

Open
osdiab opened this issue Nov 11, 2021 · 1 comment
Open

No support for page anchors #25

osdiab opened this issue Nov 11, 2021 · 1 comment

Comments

@osdiab
Copy link
Collaborator

osdiab commented Nov 11, 2021 •
edited
Loading

like /myRoute#some-section

Though to be honest it seems like query params ought to just be handled separately from this library - if it were me I would limit the API surface of this just to route paths, and just deal with search params outside of this library, to contain scope.
@ckastbjerg
Copy link
Owner

I would tend to agree. I've just chosen to support query now as it was convenient for the project I created the library for. Might make sense to deprecate that functionality. I'll think about it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@osdiab @ckastbjerg