Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark disallowed schema definitions based on the model selection #157

Open
pomek opened this issue May 24, 2022 · 1 comment
Open

Mark disallowed schema definitions based on the model selection #157

pomek opened this issue May 24, 2022 · 1 comment

Comments

@pomek
Copy link
Member

pomek commented May 24, 2022

The new Schema tab (#155) shows all schema entries registered in an editor, which significantly improves understanding of the model limitations. Thanks for adding it.

image

I believe we can improve the list by marking (e.g., gray out) items disallowed in the given context based on the selection, similar to the Commands view.

image

So, for the given model:

image

The imageBlock definition will be grayed out as the editor does not allow adding of block images in captions.

image

@pomek pomek added type:improvement intro squad:platform Issue to be handled by the Platform team. labels May 24, 2022
@oleq
Copy link
Member

oleq commented May 24, 2022

Pros:

  • Aligned with the commands pane that also displays whether a command is enabled or not.

Cons:

  • Could be a source of confusion because the user may not be able to connect the state of the Schema pane to the Model pane they don't see. They may be confused why some definitions are "available" and some are not (greyed out). 
    • Commands also react to other editor states (e.g. read only) so the analogy to the Commands pane may not be the best.
    • OTOH, they may eventually figure this out by moving the selection.

@pomek pomek removed the squad:platform Issue to be handled by the Platform team. label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants