Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments editor includes unnecessary plugins #17632

Open
bendemboski opened this issue Dec 11, 2024 · 0 comments
Open

Comments editor includes unnecessary plugins #17632

bendemboski opened this issue Dec 11, 2024 · 0 comments
Labels
type:bug This issue reports a buggy (incorrect) behavior.

Comments

@bendemboski
Copy link
Contributor

πŸ“ Provide detailed reproduction steps (if any)

Create an editor with comments enabled

βœ”οΈ Expected result

The SelectAllEditing and UndoEditing plugins are included, but the SelectAllUI and UndoUI plugins are not

❌ Actual result

UI plugins are included

❓ Possible solution

Make the comments plugins only import/require SelectAllEditing rather than the SelectAll glue plugin and UndoEditing rather than the Undo glue plugin

πŸ“ƒ Other details

Based on my bundle analysis, the comments editor imports and requires the SelectAll and Undo glue plugins, but it doesn't have a tool bar or application menu or anything, so only needs the editing plugins. This inflates the bundle size anytime comments is included in the build, and (slightly) bloats the comment editors unnecessarily at runtime.


If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@bendemboski bendemboski added the type:bug This issue reports a buggy (incorrect) behavior. label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

1 participant