-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring random-js back up to speed with newer webpack and node #65
base: master
Are you sure you want to change the base?
Conversation
Oh wow, thanks for this!
I'm really not sure if I care in 2023
You're a gem 💎 I'll take a further look this weekend and hopefully merge this in, as long as it doesn't introduce any unexpected breakages. A large part of me wants to revamp the entire package, or split it into multiple pieces, or some other mechanism to make sure it's as easy as possible to tree-shake. The best approach for that is probably to spruce it up while keeping it the same (read: this PR), then make decisions from there. |
This would likely become a sufficient base for version 3.0 |
OK, I answered #38 and will try to close it with the merging of this PR once it's all finished |
@ckknight I'm getting back onto this PR, was kinda hard to think about where to start without putting up a todo list of everything that needs done before it's ready for merge |
Made sense to convert this to a draft, college work has gotten in the way, I'll be back to work on this hopefully soon |
All dependencies have been updated to their latest versions, linter errors have been fixed, build errors in webpack 5+ have been fixed, there are many things that have changed (even the author's credit got updated to her correct name, she is Summer now).
One unfortunate side effect of the updates is that ES3 support is dropped. @ckknight please let me know if there are any more things you want me to do before this gets merged, I'm sure I got everything covered.
Things left to do in this PR:
min
andmax
commands (fixing Force value to either min or max #42)Math.random()
using this engine (fixing Question: replicating exact functionality of Math.random() #38)randomInt()
is biased (fixing More information about randomInt being biased? #13 using info from More information about randomInt being biased? #13 (comment) and helping better explain why a library like this one is necessary)npm test
(secondary objective yet will be a lot cleaner when tests are run)random-js-no-node
and link to it somewhere in the READMEFixes #69
Fixes #68
Fixes #64
Closes #63
Closes #62
Closes #61
Closes #60
Fixes #59
Closes #58
Closes #57
Closes #56
Fixes #55
Closes #54
Closes #53
Closes #52
Closes #50
Closes #49
Closes #48
Closes #46
Closes #45
Fixes #43
Fixes #42
Fixes #40
Closes #39
Fixes #38
Fixes #35
Fixes #33
Fixes #22
Fixes #13