correct behaviour

[bquast]

Hi, I like the idea of these hooks a lot.

I tried using them, but my repo ends up containing my basic.xlsx and a folder .~basic is this the intended behaviour?

From the README I get the idea that it would only be the contents of the folder, did I do something wrong, or do git hooks work differently from 7 years ago?

thanks,
Bastiaan

https://github.com/bquast/basic/

[ckrf]

Thanks! If I recall correctly, this is the correct behavior. The hooks leave a file called "basic.xlsx" in the repo, but it is not an Excel file. It is a "placeholder" text file. All the content is actually stored in the folder ".~[name]".

[bquast]

Thanks for writing back.

Perhaps I could add the placeholder to .gitignore.

Would it be possible to modify the hooks so that instead of storing in ".~[name]", they are just stored in root directory of the repo?

[bquast]

Separately (perhaps you know more), I notice that a lot of the XML is not needed, a whole history of when what value was written to which cell, instead of just the most recent version. Would there be a way to strip all this.

For instance, would Excel still open an XSLX file if the timestamp is e.g. NA?

[ckrf]

On cleaning up the XML, it sounds like a great idea - I don't know anything about what Excel needs to be able to open a file, unfortunately. I would discourage you from adding the placeholder to .gitignore. It might break the hooks altogether, or it might just break the protection in the hooks against deleting an excel file with uncommitted changes. In principle you should be able to modify the hooks to store the xml files in the repo root directory, but that would mean that you could only have one xlsx file in the repo.

…

On Tue, Dec 27, 2022 at 11:55 AM Bastiaan Quast ***@***.***> wrote: Separately (perhaps you know more), I notice that a lot of the XML is not needed, a whole history of when what value was written to which cell, instead of just the most recent version. Would there be a way to strip all this. For instance, would Excel still open an XSLX file if the timestamp is e.g. NA? — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABHMJWBLPTAL4K72RYOXYEDWPMUSRANCNFSM6AAAAAATJ6M5D4> . You are receiving this because you commented.Message ID: ***@***.***>

[bquast]

Okay thanks.

Yes one XLSX file is fine.

What I did is remove:

# -- config -- #
TMP_PREFIX='.~' # prefix XML directory--should NOT conflict with 
                   # anything in your repo

# -- end config -- #

and:

-d "${TMP_PREFIX}$1

I end up with the XML files in root, but not reflowed and not staged.

Is there something I am missing?