Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe related fake data #31

Open
mainrs opened this issue Feb 22, 2020 · 5 comments
Open

Add recipe related fake data #31

mainrs opened this issue Feb 22, 2020 · 5 comments

Comments

@mainrs
Copy link
Contributor

mainrs commented Feb 22, 2020

I'm currently needing fake data for recipe and ingredients, including separated lists for vegetables, fruits, nuts etc.

I'd imagine something like this:

enum Category {
  Fruit,
  Vegetable,
  Nut,
  // etc...
}

Ingredient(category: Option<Category>);
Ingredients(count: usize, category: Option<Category>);
Recipe();
Recipes(count: usize);

As of now, I do not have recipe steps implemented but might add them later on. One thing that might actually be better would be moving the Ingredient call to a separate call like Fruit(), Vegetable(), Nut() and have Recipe re-use them. That way, they are not coupled to recipes and should make it clear that they can be used by their own.

If there is interest I can open a PR so you can merge my additions back into master.

@cksac
Copy link
Owner

cksac commented Feb 22, 2020

Sure, PR welcome🙂

@pickfire
Copy link
Contributor

@sirwindfield Ping

@mainrs
Copy link
Contributor Author

mainrs commented Feb 23, 2021

Ah, I totally forgot about this, sorry! I will get around this in two weeks when I have vacation :)

@pickfire
Copy link
Contributor

@sirwindfield I just ping you but not for the interested of using this. It's still up to you to do it, I don't need it.

@mainrs
Copy link
Contributor Author

mainrs commented Feb 23, 2021

I see! I already had the list available and lying around and I don't think incorporating it would be too much effort :) Contributing back to some libraries I use ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants