Skip to content
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.

hdb-pool does not disclose dependencies correctly #13

Open
lucasheim opened this issue Sep 10, 2021 · 0 comments
Open

hdb-pool does not disclose dependencies correctly #13

lucasheim opened this issue Sep 10, 2021 · 0 comments

Comments

@lucasheim
Copy link

The full explanation for this issue can be found here.

Basically, when using yarn with pnp, yarn is really strict with dependency management, so you should not require dependencies which are not correctly declared in the package.json. As of now, hdb-pool requires @sap/hana-client in Utils but it does not declare it as a dependency in the package.json, only as a devDependency.

Because of this, a yarn pnp project trying to use any package that depends on hdb-pool (like typeorm) will fail and it needs to do a workaround in .yarnrc.yml:

...
packageExtensions:
  "hdb-pool@^0.1.6":
    dependencies:
      "@sap/hana-client": "^2.9.28"

To fix this, please just move hdb-pool from a devDependency to a dependency. For now, I'm not sure if any other package should also make this move.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant