Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

massive refactoring required #31

Closed
keighrim opened this issue Nov 18, 2023 · 4 comments
Closed

massive refactoring required #31

keighrim opened this issue Nov 18, 2023 · 4 comments

Comments

@keighrim
Copy link
Member

keighrim commented Nov 18, 2023

Because

As there are many instances of "copies" of python scripts/functions/methods in the project root directory, the codebase is really hard to read and review. For example, I spent 30 mins to figure out why my edits were now properly staged until I realized that there are to classify.py files when I first started reviewing the app submission. De-cluttering these stopgap practice will highly improve readability and maintenance of the codebase.

Done when

Only one copy of all classes, modules, methods, and functions related to training and classification are left and properly packaged in a python package.

Additional context

No response

@keighrim
Copy link
Member Author

done via #32

@keighrim
Copy link
Member Author

Reopening this as we change to course and decided to release v1.0 with the duplicate code.

@marcverhagen
Copy link
Contributor

Duplicate code is gone I think. One remaining thing that I can think of is to split classification of images from generation of timeframes (now they are not closely entangled, but still in the same file).

@marcverhagen
Copy link
Contributor

Refactoring will continue, but the massive changes that were needed are all done I think.

@github-project-automation github-project-automation bot moved this from Todo to Done in apps Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants