Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with configurations without pre-binning #64

Closed
marcverhagen opened this issue Feb 7, 2024 · 1 comment
Closed

Deal with configurations without pre-binning #64

marcverhagen opened this issue Feb 7, 2024 · 1 comment
Milestone

Comments

@marcverhagen
Copy link
Contributor

Because

Models without any pre-binning were not dealt with before in the classifier/stitcher code, so it is not surprising that the stitcher breaks on this because it uses the pre-bin labels.

Done when

No response

Additional context

No response

@marcverhagen marcverhagen added this to the swt-v3 milestone Feb 7, 2024
@marcverhagen marcverhagen self-assigned this Feb 7, 2024
@marcverhagen
Copy link
Contributor Author

The classifier also breaks on this since it relies on there being pre-bins:

self.classifier = train.get_net(
in_dim=self.featurizer.feature_vector_dim(),
n_labels=len(self.model_config['bins']['pre'].keys()) + 1 if 'pre' in self.model_config['bins'] else 23,
num_layers=self.model_config["num_layers"],
dropout=self.model_config["dropouts"])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant