-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase default value for stopAt
parameter
#95
Comments
After reading this issue, I was tempted to use the maximum integer value. Then, I found this comment in the code; Lines 42 to 43 in 710f527
@marcverhagen is this about python 2 v. 3 compatibility issue of |
@keigh Not sure why I thought 10M is better than maxsize (old habit of mine to use maxint, not about compatibility issues). Maybe I did not want a default that would allow processing to continue for years, but why not? I have changed this to use sys.maxsize and this will be in version 5.0. |
From the v5.0 app directory page:
Yeah, I think that should be just about high enough. LOL (Also, thank you!) |
Because
The current default for
stopAt
is 10,000,000 ms. This is less than 3 hours. Although it would be unusual, it is possible that an AAPB video could be longer than that.I'd recommend a default value of 86,400,000 ms, which is 24 hours.
Done when
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: