Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase default value for stopAt parameter #95

Closed
owencking opened this issue Apr 15, 2024 · 3 comments
Closed

increase default value for stopAt parameter #95

owencking opened this issue Apr 15, 2024 · 3 comments

Comments

@owencking
Copy link
Collaborator

Because

The current default for stopAt is 10,000,000 ms. This is less than 3 hours. Although it would be unusual, it is possible that an AAPB video could be longer than that.

I'd recommend a default value of 86,400,000 ms, which is 24 hours.

Done when

No response

Additional context

No response

@keighrim
Copy link
Member

After reading this issue, I was tempted to use the maximum integer value. Then, I found this comment in the code;

# 10M ms is almost 3 hours, that should do; this is better than sys.maxint
# (also, I tried using default=None, but that made stopAt a required property)

@marcverhagen is this about python 2 v. 3 compatibility issue of sys.maxint?

@marcverhagen
Copy link
Contributor

@keigh Not sure why I thought 10M is better than maxsize (old habit of mine to use maxint, not about compatibility issues). Maybe I did not want a default that would allow processing to continue for years, but why not?

I have changed this to use sys.maxsize and this will be in version 5.0.

@owencking
Copy link
Collaborator Author

From the v5.0 app directory page:

stopAt: optional, defaults to 9223372036854775807

Yeah, I think that should be just about high enough. LOL

(Also, thank you!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants