Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discussion on consumer specs #93

Open
keighrim opened this issue Feb 14, 2022 · 3 comments
Open

discussion on consumer specs #93

keighrim opened this issue Feb 14, 2022 · 3 comments
Assignees
Labels
▶️F Migrate to next phase
Milestone

Comments

@keighrim
Copy link
Member

keighrim commented Feb 14, 2022

(related: cataloguing consumer apps clamsproject/apps#22)

@keighrim keighrim added the ▶️F Migrate to next phase label Nov 22, 2022
@keighrim keighrim added this to CLAMS Mar 18, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in CLAMS Mar 18, 2023
@keighrim
Copy link
Member Author

keighrim commented Apr 3, 2023

I added https://github.com/clamsproject/consumer-evaluation repository, based on assumption that evaluation code will be consumers of MMIF. However, often ML evaluation pipeline takes a collection of documents instead of a single document, but the way other consumers we have currently were developed has been to handle a single MMIF input.

That said, my questions:

  1. Should evaluation code (or pipeline) be "consumers"? the repository in question is now renamed.
  2. More generally, should we limit the scope of the consumers to handling of a single input at a time? Or putting in other words, should we introduce a new class for "collection" consumers? Besides of evaluation, I can see dashboard builders (we talked about a possibility of using elastic-kibana for this) fall into this category.

@keighrim keighrim added the Epic Used for Zenhub label Apr 21, 2023
@clams-bot clams-bot added this to infra Apr 23, 2023
@github-project-automation github-project-automation bot moved this to Todo in infra Apr 23, 2023
@marcverhagen
Copy link
Contributor

We could start with limiting consumers to one MMIF file at the time, like the producers. It is possible that there are use cases for collection-level consumers (and maybe collection-level producers as well), the question there is whether it is better to add collection consumers to the code here or run a batch like GBH does.

@keighrim
Copy link
Member Author

Regarding "interface" of the consumers;

The first consumer (prototype) was mmif-visualizer and it was developed not only as a standalone web app, but also as a "display application" integrated to the galaxy workflow engine.

The /display route in the mmif-viz was originally designed for such integration to galaxy

https://github.com/clamsproject/mmif-visualizer/blob/1ff27c6c48ff04b37de714719aaa5776cd8acfe8/app.py#L41-L44

https://github.com/clamsproject/wfe-galaxy/blob/dec9e60472c229efb7161c148e95e21012b74c22/make_appliance.py#L416

(but during recent updates, the route has been re-purposed, and no longer support galaxy integration)

However, given

  1. we don't have a clear answer to Summarizer usage and functionality mmif-summarizer#9 , and
  2. having a common user interface or "entry point" for all consumers DOES make a lot of sense

I'd like to go back to the idea of using HTTP as the common interface, and want bring a common route (that any HTTP clients can call, including galaxy engine) defined in the interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
▶️F Migrate to next phase
Projects
Status: 🆕 New
Status: Next
Development

No branches or pull requests

4 participants