Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverting 1.1.0 release #216

Closed
keighrim opened this issue Feb 7, 2024 · 1 comment · Fixed by #217
Closed

reverting 1.1.0 release #216

keighrim opened this issue Feb 7, 2024 · 1 comment · Fixed by #217

Comments

@keighrim
Copy link
Member

keighrim commented Feb 7, 2024

Because

With the release of 1.1.0, we introduced refinedParameters field in the view metadata. (#208) However, as I mentioned in the body of that issue, I was skeptical from the beginning on adding such a new field.

but I wonder if there's any value in adding one (optional) field in the MMIF to record the configuration after the "normalization" (@keighrim)

And now that I have another datapoint that shares the same skepticism(#214 (review))

I see how we want the parameters to contain the original ones as given by the user, but am not quite sure why we also need to keep track of the refined ones for reproducability. (@marcverhagen )

, I'm proposing we "un-release 1.1.0" and go back to 1.0.x. with removal of refinedParameters field.

Done when

Since there has been no SDK released on top of MMIF spec 1.1.0, I think we can safely assume that MMIF 1.1.0 was never "used" in any significant way. That said, the un-releasing will involve

  1. rebasing main branch
  2. re-build web pages from rebased branch with version stamp of 1.0.x
  3. force-push to main to overwrite the published website on mmif.clams.ai

Additional context

No response

@marcverhagen
Copy link
Contributor

It is indeed unlikely that MMIF 1.1.0 was ever used, so I agree with this action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants