-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMDIDataProcessor.process(...) not thread-safe #367
Comments
We have not run into such concurrency problems with the VLO itself, which processes files in parallel as well. Therefore I would like to see it ruled out that the curation specific objects and service implementations passed to the constructor of |
Regarding the apparent fix for clarin-eric/curation-dashboard#165: an hypothesis to consider is that synchronising the call in the curation logic creates a bottleneck that 'fixes' (obscures) a concurrency problem elsewhere. |
The difference in behaviour in concurrent operation between VLO and curation is explained by the version of VTD-XML used. Won't fix in VLO 4.x |
Issue specific to VTD-XML upgrade -> #369 |
In an multi-threaded environment the method CMDIDataProcessor.process(...) returns a CMDIEntity object which differs from those in single-threaded environment at least in the Map, which is returned by CMDIdata.getDocument().
Hence, if the process method is supposed to work in a multi-threaded environment it is a bug. The issue is related to the curation-dashbord issue clarin-eric/curation-dashboard#165
The text was updated successfully, but these errors were encountered: