Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration to enable/diable legacy support (KWIC Data View) #2

Open
Querela opened this issue Jun 2, 2023 · 1 comment
Open

Add configuration to enable/diable legacy support (KWIC Data View) #2

Querela opened this issue Jun 2, 2023 · 1 comment
Assignees
@Querela

Comments

@Querela
Copy link
Contributor

Querela commented Jun 2, 2023

Currently, to remain compatible with legacy SRU/FCS clients, the (deprecated) KWIC DataView is sent in addition to the HITS DataView. The current FCS libraries handle the conversion of KWIC to HITS in the background but also receive double the results as a result.
See issue: clarin-eric/fcs-sru-aggregator#73
To solve this at the endpoint level, introduce an configuration flag of whether the KWIC Data View should still be sent or just the HITS Data View only.
@Querela Querela self-assigned this Jun 2, 2023
@Querela
Copy link
Contributor Author

Querela commented Jun 12, 2023

Commit 9bcbe0f disables Legacy KWIC Data View.
Optional web.xml config param eu.clarin.sru.cqibridge.supportLegacyKWIC allows to re-enable it to support legacy clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Querela Querela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Querela