-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for browser.windows.* APIs #89
Comments
Yes, please do! I'd love a PR to add support. 🔨 |
I made the mocks for the windows api (see here) but I just had a question about how In the documentation for the So I have two questions:
|
I'm guessing you'll need to fix that and it was just stubbed out.
In a number of places where this is a concern we use a pattern like this: jest-webextension-mock/src/browserAction.js Lines 1 to 6 in 3a37dd9
|
Any progress on this? :) |
First of all thanks for making this library, it seems really promising!
I was trying to use this library in my extension and followed the instructions in the README but I keep getting this error when I run certain tests:
I think the issue is just that there are no mocks for this part of the API yet (correct me if I am wrong). Let me know if this is actually an issue or I am just misusing the library.
If it is just a case of missing support, I think we can add it. If you want I can make a PR to add these mocks, I looked over the existing source code and I think I understand how this library works.
Thanks!
The text was updated successfully, but these errors were encountered: