Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PacketStream up/down converter less strict on the required width. #100

Closed
rowanG077 opened this issue Jul 31, 2024 · 1 comment
Closed

Make PacketStream up/down converter less strict on the required width. #100

rowanG077 opened this issue Jul 31, 2024 · 1 comment

Comments

@rowanG077
Copy link
Member

The up/down width converters for the PacketStream protocol can only go from width 1 to n and back. Without much of the implementation changing it should be possible to go from p to p * n and from p * n to p. This way you could also convert from 2 to 4 for example.
@rowanG077 rowanG077 changed the title Make PacktetStream up/down converter more polymorphic on the input. Make PacktetStream up/down converter less strict on the required width. Jul 31, 2024
@rowanG077 rowanG077 changed the title Make PacktetStream up/down converter less strict on the required width. Make PacketStream up/down converter less strict on the required width. Jul 31, 2024
@t-wallet
Copy link
Collaborator

t-wallet commented Aug 2, 2024

Implemented in #85

@t-wallet t-wallet closed this as completed Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rowanG077 @t-wallet