Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning in Logger at HA Startup #60

Open
foxxcomm opened this issue Mar 23, 2024 · 13 comments
Open

Warning in Logger at HA Startup #60

foxxcomm opened this issue Mar 23, 2024 · 13 comments

Comments

@foxxcomm
Copy link

We see these in the System logs at each HA Startup. Looks fairly minor but thought you may want to have a look during next update cycle. Looks like it applies to both the Neviweb (sinope-1) and the gt125 versions of the integration.

Thank You for your great Sinope integrations!


Logger: homeassistant.components.climate
Source: components/climate/init.py:361
integration: Climate (documentation, issues)
First occurred: 14:42:41 (2 occurrences)
Last logged: 14:42:44

Entity None (<class 'custom_components.sinope.climate.SinopeThermostat'>) implements HVACMode(s): off, auto, heat and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please report it to the author of the 'sinope' custom integration

Entity None (<class 'custom_components.neviweb.climate.NeviwebThermostat'>) implements HVACMode(s): off, auto, heat and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please report it to the author of the 'neviweb' custom integration

@claudegel
Copy link
Owner

Sorry didn't see your issue. Normally I receive an email about new issue but nothing this time.
This have been solve in my other custom components. I'll fix it soon.

@claudegel
Copy link
Owner

Ok I've created a new branch
https://github.com/claudegel/sinope-gt125/tree/turn-0n-0ff
Only the file climate.py have changes
I still need to test on my side but if you want to test. replace your sinope/climate.py by the one in the new branch.

@claudegel
Copy link
Owner

On my side no error. Please test on your side before I merge

@foxxcomm
Copy link
Author

Thanks for your work on this. I tested here and still seeing the following warning on HA startup. Wondering if this is your other plug-in for Sinope web however as I have both installed:

Logger: homeassistant.components.climate
Source: components/climate/init.py:363
integration: Climate (documentation, issues)
First occurred: 01:21:58 (1 occurrences)
Last logged: 01:21:58

Entity None (<class 'custom_components.neviweb.climate.NeviwebThermostat'>) implements HVACMode(s): off, auto, heat and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please report it to the author of the 'neviweb' custom integration

@claudegel
Copy link
Owner

Ok I'll do the other one, neviweb, tonight and let you know when it is ready to test.

@claudegel
Copy link
Owner

Ok the other one is ready to test.
https://github.com/claudegel/sinope-1/tree/turn-on-off/custom_components/neviweb
only file climate.py have changed
Let me know if it work

@foxxcomm
Copy link
Author

Tested and HA warnings at startup are fixed.

Thank You

@claudegel
Copy link
Owner

can you test the service climate.turn_off with on of your thermostats in the neviweb component to see if the thermostat will go off ?
if it work I'll push a release for neviweb and sinope.
Thanks for your help

@foxxcomm
Copy link
Author

Tested under HA 2024.5.4 calling Climate: Turn Off and Climate: Turn on from Developer Tools -> Services:

Both functions do work in that I see the thermostat turn off on However: After clicking CALL SERVICE (both off and on), I don't see the CALL SERVICE button change color from BLUE to GREEN and display a check mark.

I then tested with my other climate entities and the CALL SERVICE button changes as expected to GREEN with a check mark. Guess is that your missing some confirmation call back to HA??

@foxxcomm
Copy link
Author

Repeating the test with Log Viewer open, I'm seeing the following WARNINGS which may be related to this:

2024-05-23 20:53:39.834 WARNING (MainThread) [homeassistant.helpers.entity] Update of climate.neviweb_climate_masterbath is taking over 10 seconds
2024-05-23 20:53:40.202 WARNING (MainThread) [homeassistant.helpers.entity] Update of sensor.neviweb_sensor_gt125 is taking over 10 seconds
2024-05-23 20:59:10.202 WARNING (MainThread) [homeassistant.helpers.entity] Update of sensor.neviweb_sensor_gt125 is taking over 10 seconds
2024-05-23 21:00:56.792 WARNING (MainThread) [homeassistant.helpers.entity] Update of climate.neviweb_climate_masterbath is taking over 10 seconds
2024-05-23 21:10:10.205 WARNING (MainThread) [homeassistant.helpers.entity] Update of sensor.neviweb_sensor_gt125 is taking over 10 seconds

@claudegel
Copy link
Owner

That warning about update is because Neviweb do not send back the update fast enough.
The climate.turn_on/off is not a service from my component but it is done directly by HA. Normally for my services I check the answer from Neviweb and add that answer info in the log. But it look like HA services don't work the same.
If you say that climate.turn_off effectively turn thermostat off and climate.turn_on effectively turn back on the thermostats then it is just a delay from Neviweb answer that prevent the GREEN display and check mark to appear soon enough.
Normally if a service do not succeed it goes from BLUE to RED with a message on the bottom of the screen. So for me the turn_on/off services are working.
Can you check with sinope thermostats name instead of the neviweb thermostat name ?

@claudegel
Copy link
Owner

In your log you should see line like this
ATTR_SETPOINT_MODE:...

Data = {'onOff': 'off'}  <-- what we send
Request response = 200  <-- acknowledgement from Neviweb
Json Data received = {'onOff': 'off'} <--reply from Neviweb

Data is what is sent to Neviweb and the two other lines are what Neviweb reply. If you see this everything is fine.

@foxxcomm
Copy link
Author

foxxcomm commented May 25, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants