Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for specifying file name #325

Open
1 of 4 tasks
0WN463 opened this issue Apr 22, 2024 · 2 comments
Open
1 of 4 tasks

Add option for specifying file name #325

0WN463 opened this issue Apr 22, 2024 · 2 comments

Comments

@0WN463
Copy link

0WN463 commented Apr 22, 2024

I'm opening this issue because:

  • I have found a bug
  • I want to request a feature
  • I have a question
  • Other

Suggestion to add file name as an option.

Right now, we can specify the output dir using output, but I want to be able to specify the file name.

The quickest way to implement this would be something like a output-file option or filename option.

But my further suggestion is to use --output to specify the file name, and --output-dir to specify the directory instead.
Even though this might be backwards incompatible, it follows the flag format of other CLI tools.

In addition, I 'd like the option to dump the file content into stdout by using --output -.

My main use case is that usually I have a link on my phone that I wish to transfer to my computer.
I don't need the link as a file, I only need it into my clipboard manager, so with this option, I can use qrcp receive --output - | clipboard_manager.

If this sounds ok, I can create a PR that adds this feature.

@claudiodangelis
Copy link
Owner

Hello, sorry I missed this issue.
Sure, please feel free to start a PR if you'd like.
Thanks,
C

@0WN463
Copy link
Author

0WN463 commented Oct 5, 2024

Ok, I've created a PR to support this #339 , where I renamed the flags and added the file flag.

Will create another one to add an option to dump the QR code and system logs to stderr instead so that the output can be piped properly

EDIT: I've opened #341 too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants