Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined names in storm.py #623

Closed
bolliger32 opened this issue Jul 8, 2024 · 3 comments
Closed

Undefined names in storm.py #623

bolliger32 opened this issue Jul 8, 2024 · 3 comments

Comments

@bolliger32
Copy link
Contributor

My linter is noticing that seconds2date and fileWrite seem to be undefined in storm.py. Did these used to be defined somewhere? I don't think these get used often but it looks like it will affect write_atcf, write_hurdat, write_jma, and make_multi_structure, which isn't actually called anywhere.

@mandli
Copy link
Member

mandli commented Jul 8, 2024

What branch/version are you on? A linter is now going to be run on PRs but the changes that fix some failures has not been merged yet (#610). There was some things in there that needed to be commented out as they did not work consistently and had some cruft buildup.

@bolliger32
Copy link
Contributor Author

@mandli you're right I was looking at master and didn't see #610, which I think fixes this.

@mandli
Copy link
Member

mandli commented Jul 8, 2024

There are a number of things that needed to be fixed. Hopefully we can get the testing up and running sooner rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants