Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using Releases #40

Open
xtrasmal opened this issue Sep 8, 2024 · 2 comments
Open

Start using Releases #40

xtrasmal opened this issue Sep 8, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@xtrasmal
Copy link

xtrasmal commented Sep 8, 2024

Hi there,

When adding grammars, folks use specific commits to point to. Usually the commit of a release.

id = "php"
name = "PHP"
description = "PHP support."
version = "0.1.3"
schema_version = 1
authors = ["Piotr Osiewicz <[email protected]>"]
repository = "https://github.com/zed-industries/zed"

[language_servers.intelephense]
name = "Intelephense"
language = "PHP"
language_ids = { PHP = "php"}

[language_servers.phpactor]
name = "Phpactor"
language = "PHP"

[grammars.php]
repository = "https://github.com/tree-sitter/tree-sitter-php"
commit = "a1e0befae61715d9e162529b3c2bfd961d183613"
path = "php"

[grammars.phpdoc]
repository = "https://github.com/claytonrcarter/tree-sitter-phpdoc"
commit = "1d0e255b37477d0ca46f1c9e9268c8fa76c0b3fc"

This is how Zed does it. It would be great to rely on a certain release :)

@claytonrcarter
Copy link
Owner

Not opposed, but I would need someone to PR a CI workflow so that I can push a tag to create a release, ideally w/ auto changelog, etc. As I understand it, most of the consumers of this project have been fine to just directly reference a SHA directly instead of a release tag. That's what Zed and nvim are doing, as I understand it.

So I don't plan to do this, but would welcome a PR. 😄

@claytonrcarter claytonrcarter added the good first issue Good for newcomers label Oct 11, 2024
@mavit
Copy link

mavit commented Dec 19, 2024

Just pushing tags would achieve what the reporter is asking for, here, I believe.

Sure, it's possible to set up a fancy CI pipeline to populate the "Releases" section on GitHub, and/or push tarballs to npm, crates.io, PyPI or where-ever, but I think those are separate issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants