Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is there a way to revive DateFacet and ArrayFacet? #5

Open
cldellow opened this issue Feb 1, 2023 · 0 comments
Open

is there a way to revive DateFacet and ArrayFacet? #5

cldellow opened this issue Feb 1, 2023 · 0 comments

Comments

@cldellow
Copy link
Owner

cldellow commented Feb 1, 2023

The Facet class gets a reference to its database, so we can generate DuckDB specific queries

Another challenge might be expressing the filter. Dates in parquet aren't strings, so created LIKE '2023-01-01%' won't work.

I'm a little afraid that we'd need actual proper support from Datasette

I could imagine doing some crazy hacks to make it work, if we really wanted to: take over all the filter generation, consulting the type of the column to know whether to do a simple string LIKE or a date comparison

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant