Skip to content

Commit 889f685

Browse files
author
Craig J. Bass
committed
Because group toggles should be handled the same as user toggles in this scenario (#16)
1 parent 98c84eb commit 889f685

File tree

2 files changed

+0
-16
lines changed

2 files changed

+0
-16
lines changed

src/Toggle/CanDefaultToggleStatusBeOverruled.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,6 @@ public function canBeOverruled( $toggleName, array $segments )
4343
return false;
4444
}
4545

46-
$isGroupToggle = $this->toggleGateway->isGroupToggle( $toggleName );
47-
if ( $isGroupToggle ) {
48-
return true;
49-
}
50-
5146
$lockedSegments = $this->segmentLockedPropertyFilter->filterLockedSegments( $segments );
5247
$lockedSegmentPolicyResult = $this->segmentPolicyEvaluator->evaluateSegmentPoliciesForToggle( $toggleName, $lockedSegments );
5348
return $lockedSegmentPolicyResult === null;

test/Toggle/CanDefaultToggleStatusBeOverruledTest.php

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -101,17 +101,6 @@ public function GivenSegmentPolicySetForLockedSegment_ExpectFalse()
101101
$this->assertCannotBeOverruledGivenSegments( $segments );
102102
}
103103

104-
/**
105-
* @test
106-
*/
107-
public function GivenGroupToggleAndLockedSegment_ExpectTrue()
108-
{
109-
$segments = [ new SegmentStub( 1, 1, true ) ];
110-
$this->toggleGatewayMock->setIsGroupToggle( self::TOGGLE_NAME, true );
111-
$this->segmentTogglePolicyGatewayMock->setTogglePolicyDisabled( self::TOGGLE_NAME, $segments[0] );
112-
$this->assertCanBeOverruledGivenSegments( $segments );
113-
}
114-
115104
/**
116105
* @test
117106
*/

0 commit comments

Comments
 (0)