Because group toggles should be handled the same as user toggles in t…

…his scenario (#16)
clearbooks · Jun 9, 2016 · 889f685 · 889f685
1 parent 98c84eb
commit 889f685
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 16 deletions.
diff --git a/src/Toggle/CanDefaultToggleStatusBeOverruled.php b/src/Toggle/CanDefaultToggleStatusBeOverruled.php
@@ -43,11 +43,6 @@ public function canBeOverruled( $toggleName, array $segments )
             return false;
         }
 
-        $isGroupToggle = $this->toggleGateway->isGroupToggle( $toggleName );
-        if ( $isGroupToggle ) {
-            return true;
-        }
-
         $lockedSegments = $this->segmentLockedPropertyFilter->filterLockedSegments( $segments );
         $lockedSegmentPolicyResult = $this->segmentPolicyEvaluator->evaluateSegmentPoliciesForToggle( $toggleName, $lockedSegments );
         return $lockedSegmentPolicyResult === null;

diff --git a/test/Toggle/CanDefaultToggleStatusBeOverruledTest.php b/test/Toggle/CanDefaultToggleStatusBeOverruledTest.php
@@ -101,17 +101,6 @@ public function GivenSegmentPolicySetForLockedSegment_ExpectFalse()
         $this->assertCannotBeOverruledGivenSegments( $segments );
     }
 
-    /**
-     * @test
-     */
-    public function GivenGroupToggleAndLockedSegment_ExpectTrue()
-    {
-        $segments = [ new SegmentStub( 1, 1, true ) ];
-        $this->toggleGatewayMock->setIsGroupToggle( self::TOGGLE_NAME, true );
-        $this->segmentTogglePolicyGatewayMock->setTogglePolicyDisabled( self::TOGGLE_NAME, $segments[0] );
-        $this->assertCanBeOverruledGivenSegments( $segments );
-    }
-
     /**
      * @test
      */