Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing tree view for bundle-list --deps #1261

Merged
merged 2 commits into from
Jan 17, 2020
Merged

Implementing tree view for bundle-list --deps #1261

merged 2 commits into from
Jan 17, 2020

Conversation

castulo
Copy link
Contributor

@castulo castulo commented Jan 8, 2020

Sometimes is useful to see the list of dependencies in a tree view form, for example when trying to remove bundles from a system.

This commit adds the ability of listing the dependencies of a bundle in a tree view when --verbose is used.

Example:

$ sudo ./swupd bundle-list --deps vim
Loading required manifests...

Bundles included by vim:
 - findutils
 - lib-openssl
 - libstdcpp
 - os-core
 - p11-kit
 - perl-basic
 - python3-basic

Total: 7

$ sudo ./swupd bundle-list --deps vim --verbose
Loading required manifests...

Bundles included by vim:
  * vim
    |-- perl-basic
        |-- lib-openssl
            |-- p11-kit
                |-- findutils
                    |-- os-core
                |-- os-core
            |-- os-core
        |-- os-core
    |-- python3-basic
        |-- libstdcpp
            |-- os-core
        |-- p11-kit
            |-- findutils
                |-- os-core
            |-- os-core
        |-- os-core
    |-- os-core

Total: 7

Closes #929

@castulo castulo self-assigned this Jan 8, 2020
@castulo castulo force-pushed the issue_929 branch 2 times, most recently from 1f61fb3 to f151c9e Compare January 8, 2020 20:44
@castulo castulo marked this pull request as ready for review January 8, 2020 21:14
otaviobp
otaviobp approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@otaviobp otaviobp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@castulo
Remove unecessary processing from bundle-list
8587230 
This commit removes some extra processing from bundle-list --deps.

Signed-off-by: Castulo Martinez <[email protected]>
@castulo
Implementing tree view for bundle-list --deps
8e5779c 
Sometimes is useful to see the list of dependencies in a tree view form,
for example when trying to remove bundles from a system.

This commit adds the ability of listing the dependencies of a bundle in
a tree view when --verbose is used.

Closes clearlinux#929

Signed-off-by: Castulo Martinez <[email protected]>
@castulo
Copy link
Contributor Author

castulo commented Jan 17, 2020

V2:

  • rebased on master

@castulo castulo merged commit a040496 into clearlinux:master Jan 17, 2020
@castulo castulo deleted the issue_929 branch January 17, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaviobp otaviobp otaviobp approved these changes

Assignees

@castulo castulo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tree view for bundle-list dependency
2 participants
@castulo @otaviobp