Support nested fragments. #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 7, 2022 16:54
|
Can we move this forward? :) |
|
@clentfort thoughts on this? |
rwe
reviewed
Feb 24, 2024
| @@ -77,7 +88,7 @@ function mapScalar(data: any, path: PropertyKey[], map: ScalarMapping) { | |||
| if (Array.isArray(newSubData[segment])) { | |||
| const subPath = path.slice(index + 1); | |||
| newSubData[segment] = newSubData[segment].map((subData: unknown) => | |||
| mapScalar(subData, subPath, map) | |||
| mapScalar(subData, subPath, mapping) | |||
There was a problem hiding this comment.
Not a fault in either PR, but note that the renaming of map to mapping here would need to be resolved with this one in #23 if both get merged:
https://github.com/clentfort/urql-custom-scalars-exchange/pull/25/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R73
When merging the two locally I was surprised to find tests fail, and it was just that tiny little thing.
This was referenced Sep 18, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14 (and thanks to @Warxcell for the test!).