-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify whether this repo is deprecated or not #41
Comments
Shell completion is now supported by click itself and the extra package is dead. click-contrib/click-completion#37 click-contrib/click-completion#41 It is still not trivial to use because it needs to be enabled for the shell. And maybe is and always was impossible for these example .py files because they are not real commands anyway. https://click.palletsprojects.com/en/8.1.x/shell-completion/
Shell completion is now supported by click itself and the extra package is dead. click-contrib/click-completion#37 click-contrib/click-completion#41 It is still not trivial to use because it needs to be enabled for the shell. And maybe is and always was impossible for these example .py files because they are not real commands anyway. https://click.palletsprojects.com/en/8.1.x/shell-completion/
Shell completion is now supported by click itself and the extra package is dead. click-contrib/click-completion#37 click-contrib/click-completion#41 It is still not trivial to use because it needs to be enabled for the shell. And maybe is and always was impossible for these example .py files because they are not real commands anyway. https://click.palletsprojects.com/en/8.1.x/shell-completion/
Shell completion is now supported by click itself and the extra package is dead. click-contrib/click-completion#37 click-contrib/click-completion#41 It is still not trivial to use because it needs to be enabled for the shell. And maybe is and always was impossible for these example .py files because they are not real commands anyway. https://click.palletsprojects.com/en/8.1.x/shell-completion/
Shell completion is now supported by click itself and the extra package is dead. click-contrib/click-completion#37 click-contrib/click-completion#41 It is still not trivial to use because it needs to be enabled for the shell. And maybe is and always was impossible for these example .py files because they are not real commands anyway. https://click.palletsprojects.com/en/8.1.x/shell-completion/
yup. probably dead |
I understand part of the answer is here #37
So
But So: ping @glehmann @Konubinix , sorry to bother you. A word about this? IMHO one of the following should happen
Thanks! |
To me, it is dead. In my projects, I try to use the native completion as much as possible and suggest you do the same. I agree with your suggestions. I leave to @glehmann to make actions he deems appropriate. |
click's native completion should be used with click 8.0. This one is for click before 8.0. If click's completion is not as complete as this one, we (as a community) should work on the missing features directly in click. I'll add a notice at the top of the README and update the required click version to < 8.0 |
please tag a maintenance release |
This repo appears to duplicate (and maybe pre-date?) the official Click completion functionality.
Is this the predecessor to that/was that rolled into Click core at some point? If so, it might be good to:
If this is not a dupe of the click core functionality, and is instead an alternative implementation (or internal implementation component of the Click core func), it would be good to indicate that prominently in the README.
The text was updated successfully, but these errors were encountered: