adding permissions to allow google api calls. #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjahl
reviewed
Dec 14, 2023
| @@ -123,6 +123,11 @@ module "clingen_projects_iam_bindings" { | |||
| "group:[email protected]", | |||
| "group:[email protected]", | |||
| ] | |||
|
|
|||
| "roles/oauthconfig.editor" = [ | |||
There was a problem hiding this comment.
This role allows people to create oAuth endpoints in google cloud (e.g. for if you're developing apps that have a "log in with google" button). Is that the intention here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sjahl I'm taking a shot at adding permissions to allow Ryan and other clingen devs the ability to call the google apis. Let me know if I'm close or not. Please merge if it is good or just approve and I'll merge.